Skip to content

ENH: Fixing error and improving examples' test#39

Closed
dzenanz wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
dzenanz:mciFix
Closed

ENH: Fixing error and improving examples' test#39
dzenanz wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
dzenanz:mciFix

Conversation

@dzenanz
Copy link
Member

@dzenanz dzenanz commented Feb 16, 2018

Trying to push this to gerrit results in an error message:

$ git gerrit-push
Fetching gerrit master
Pushing to gerrit
Counting objects: 82, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (43/43), done.
Writing objects: 100% (82/82), 28.75 KiB | 3.19 MiB/s, done.
Total 82 (delta 69), reused 51 (delta 39)
remote: Resolving deltas: 100% (69/69)
remote:
remote: Processing changes: refs: 1, done
error: failed to push some refs to 'dzenan.zukic@review.source.kitware.com:ITK'
To review.source.kitware.com:ITK
!       HEAD:refs/for/master/mciFix     [remote rejected] (change http://review.source.kitware.com/23187 closed)

Dzenan@WinCorista MINGW64 /c/Misc/ITK-patches (mciFix)

@dzenanz
ENH: Fixing error and improving examples' test
404132c 
CMake Error at CMake/ITKModuleMacros.cmake:352 (add_subdirectory):
  add_subdirectory given source "examples" which is not an existing
  directory.
Call Stack (most recent call first):
  Modules/Remote/MorphologicalContourInterpolation/CMakeLists.txt:12 (itk_module_examples)

Change-Id: I1d1b70da30b4ed701d40d41bbd2864266df57dc5
@dzenanz dzenanz requested review from bradking and thewtex February 16, 2018 23:48
@thewtex
Copy link
Member

thewtex commented Feb 17, 2018

Thanks for the quick fix, @dzenanz !

That is an interesting error. I downloaded and pushed the patch here:

http://review.source.kitware.com/#/c/23195/

@thewtex thewtex closed this Feb 17, 2018
@dzenanz dzenanz deleted the mciFix branch February 23, 2018 14:41
@hjmjohnson hjmjohnson mentioned this pull request Apr 11, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thewtex thewtex Awaiting requested review from thewtex

@bradking bradking Awaiting requested review from bradking

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dzenanz @thewtex